fix: add import references when needed #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
0marperez
reviewed
May 22, 2025
| } else { | ||
| "$instant.fromEpochSeconds(${node.value}, 0)" | ||
| builder.addReferences(RuntimeTypes.Core.Instant) |
There was a problem hiding this comment.
Question: Is this needed here? It's already added on top
There was a problem hiding this comment.
Yeah, let me remove it.
| return if (node.isFloatingPointNumber) { | ||
| val fromEpochMilliseconds = RuntimeTypes.Core.fromEpochMilliseconds | ||
| builder.addReferences(RuntimeTypes.Core.fromEpochMilliseconds) |
There was a problem hiding this comment.
Question: Can you avoid adding this reference and just use Instant? How you do for fromEpochSeconds
There was a problem hiding this comment.
Not sure how, can you please add a suggestion instead?
There was a problem hiding this comment.
Something like this:
private fun getDefaultValueForTimestamp(builder: Symbol.Builder, node: NumberNode): String {
builder.addReferences(RuntimeTypes.Core.Instant)
return if (node.isFloatingPointNumber) {
val value = node.value as Double
val ms = round(value * 1e3).toLong()
"Instant.fromEpochMilliseconds($ms)"Basically removing builder.addReferences(RuntimeTypes.Core.fromEpochMilliseconds)
0marperez
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1287
#1287
Description of changes
This change imports the symbol references to add them to the resulting Kotlin file. Without this the codegen for protocol tests with the latest Smithy model complains about missing symbols such as
decodeBase64fromEpochMillisecondsSome of the references were added but not imported. Some others needed being added and imported.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.