Fix Document serialization of maps with null values #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhernandez35
force-pushed
the
fix-document-map-with-null-value
branch
2 times, most recently
from
401240a to
d281a17
Compare
rhernandez35
force-pushed
the
fix-document-map-with-null-value
branch
from
d281a17 to
e9f3f08
Compare
rhernandez35
changed the title
adwsingh
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that we can't serialize Document maps with null values while implementing CBOR documents. This uses the same approach that we're using in JsonDocuments$ListSerializer.
Fun fact: the JVM generates terrible stack traces when the receiver for an instance method reference is null. The reference
Document::serializeContentsthrows a NPE from a synthetic method when theDocumenthaving itsserializeContentsmethod invoked is null. You can see that the param in the first argument slot is null in the debugger and infer what's going on, but debugging runtime-generated code is always a nightmare.