update: upgrading kotlin version and kotlin compiler extension version #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
jumaallan
reviewed
Apr 28, 2025
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "java.configuration.updateBuildConfiguration": "interactive" | |||
jumaallan
reviewed
Apr 28, 2025
| //def smileVersion = findProperty('smileVersion') ?: '10.6.1-SNAPSHOT' // Uncomment this line to use the latest snapshot version also uncomment the snapshot repository | ||
| def smileVersion = findProperty('smileVersion') ?: '10.6.0' | ||
| def kotlinCompilerExtension = findProperty('kotlinCompilerExtensionVersion') ?: '1.5.14' | ||
| def kotlinCompilerExtension = findProperty('kotlinCompilerExtensionVersion') ?: '2.0.0' // Update to match Kotlin version |
There was a problem hiding this comment.
See this - https://developer.android.com/jetpack/androidx/releases/compose-kotlin
this is no longer needed after kotlin 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Story: https://app.shortcut.com/smileid/story/xxx
Summary
A few sentences/bullet points about the changes
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.
PR Type
Enhancement
Description
Upgrade Kotlin and related dependencies
Update Gradle wrapper to version 8.10.2
Add VSCode Java configuration settings
Changes walkthrough 📝
settings.json
Add VSCode Java configuration settings.vscode/settings.json
gradle-wrapper.properties
Upgrade Gradle wrapper to version 8.10.2android/gradle/wrapper/gradle-wrapper.properties