Fix handling of unbuffered byte streams that split UTF-8 char across read() calls #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smheidrich
force-pushed
the
fix-json-stream-gh-59-iterable-of-bytes
branch
from
f3b4311 to
fd946ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daggaz/json-stream#59 ran into an issue with json-stream's feature allowing users to pass iterables of bytes to
load, which makes it wrap them in aRawIOBaseinterface that pulls data from these iterables when read.That exposed a more general bug in json-stream-rs-tokenizer when it comes to handling unbuffered byte streams that return UTF-8 chars split across multiple
read()calls.This PR adds a regression test for the specific case that brought this up and fixes it.
In the future, I should add lower-level tests to ensure that situations like this are handled correctly for all other kinds of streams as well, not just unbuffered bytes (#107, #108).