Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCoA updates #60

Merged
merged 1 commit into from
Jul 20, 2016
Merged

PCoA updates #60

merged 1 commit into from
Jul 20, 2016

Conversation

akshayparopkari
Copy link
Collaborator

Description

  • PCoA_bubble.py:
    • Removed get_relative_abundance() function in favor of PhyloToAST in built function in biom_calc.
    • Plot legends will not use matplotlib’s Rectangle patch.
    • Axis labels updated to be consistent with LDA scripts.
    • Default scaling factor reduced by 10 fold, for clarity in plots.
    • This script has Python2 as well as Python3 compatible syntax.
  • PCoA.py:
    • Updated imports to conform with PEP8 style.
    • Plot legends will not use matplotlib’s Rectangle patch.
    • This script has Python2 as well as Python3 compatible syntax.

Motivation and Context

  • Consolidating figure outputs across all beta diversity scripts.
  • Making scripts compatible with Python3 syntax.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PCoA_bubble.py:
Removed get_relative_abundance() function in favor of PhyloToAST in
built function in biom_calc.
Plot legends will not use matplotlib’s Rectangle patch.
Axis labels updated to be consistent with LDA scripts.
Default scaling factor reduced by 10 fold, for clarity in plots.
This script has Python2 as well as Python3 compatible syntax.

PCoA.py:
Updated imports to conform with PEP8 style.
Plot legends will not use matplotlib’s Rectangle patch.
This script has Python2 as well as Python3 compatible syntax.
@smdabdoub smdabdoub merged commit 1f101f5 into smdabdoub:master Jul 20, 2016
@smdabdoub
Copy link
Owner

PCoA.py and PCoA_bubble.py now python 3 compatible (#50).

@akshayparopkari
Copy link
Collaborator Author

Minor update in PR #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants