Fix issues building with Lua and MacPorts #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users who happen to have Lua installed system-wide and/or have MacPorts enabled may see compile failures. This commit includes a small patch to the Redis Makefile that adjusts where CFLAGS gets inserted into the compile command to prevent these problems. This is a redo of smashedtoatoms#16, which got reverted because `asdf` apparently does not set `$ASDF_PLUGIN_PATH` itself, though it does respect it when searching for plugins.
Contributor
Author
|
@smashedtoatoms While I was at it, I also fixed smashedtoatoms/asdf-postgres#81 the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users who happen to have Lua installed system-wide and/or have MacPorts enabled may see compile failures. This commit includes a small patch to the Redis Makefile that adjusts where CFLAGS gets inserted into the compile command to prevent these problems.
This is a redo of #16, which got reverted because
asdfapparently does not set$ASDF_PLUGIN_PATHitself, though it does respect it when searching for plugins.