Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardhat-etherscan as its been deprecated in #207

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

zeuslawyer
Copy link
Collaborator

favour of hardhat-verify.

hardhat-toolbox includes hh-verify.

Add arb sepolia to custom networks for verification functionality.

favour of hardhat-verify.

hardhat-toolbox includes hh-verify.

Add arb sepolia to custom networks for verification functionality.
@zeuslawyer zeuslawyer marked this pull request as ready for review March 15, 2024 02:43
@zeuslawyer zeuslawyer requested a review from KuphJr March 15, 2024 02:50
@KuphJr
Copy link
Contributor

KuphJr commented Mar 15, 2024

Nice! Will this break the --verify flat when running the npx hardhat functions-deploy-consumer command or does that still work as expected?

@zeuslawyer
Copy link
Collaborator Author

Nice! Will this break the --verify flat when running the npx hardhat functions-deploy-consumer command or does that still work as expected?

nope-- WAI with CLI commands. See for example this verified contract on Op Sep

https://sepolia-optimistic.etherscan.io/address/0x8eb0561Ace3168930Cc698885A9e0904280cd77b#code

@zeuslawyer zeuslawyer merged commit db09771 into main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants