WIP: potential fix for vault retries#21342
Draft
patrickhuie19 wants to merge 1 commit intodevelopfrom
Draft
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
bolekk
reviewed
Feb 28, 2026
| } | ||
|
|
||
| // If a previous request with this ID already completed (success or error), | ||
| // remove it so the retry creates a fresh ServerRequest. This handles the |
Contributor
There was a problem hiding this comment.
What if one node retries but another node still wants to fetch the previously-ready response? IMO retries should use a different ID. Also the second sentence here doesn't make much sense to me, can you explain?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




https://docs.google.com/document/d/1BYTdvJsyaeBPRJzBYQHFO0H_jNE8AlpzhhF6sBM6ul8/edit?tab=t.0#bookmark=id.i64m1lo1s1wm