Skip to content

Disable vault.secrets.get() from gateway #21333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prashantkumar1982 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Disable vault.secrets.get() from gateway #21333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions core/services/gateway/handlers/vault/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,8 @@ func (h *handler) HandleJSONRPCUserMessage(ctx context.Context, req jsonrpc.Requ
return h.handlePublicKeyGetSynchronously(ctx, req, publicKeyResponseBytes, callback)

case vaulttypes.MethodSecretsGet:
// Secrets get is only allowed in non-production builds for testing purposes
// So no authorization is required
ar, err := h.newActiveRequest(req, callback)
if err != nil {
return err
}
return h.handleSecretsGet(ctx, ar)
h.lggr.Errorw("Get requests not allowed", "requestID", req.ID)
return errors.New("get request not allowed")
}

isAuthorized, owner, err := h.requestAuthorizer.AuthorizeRequest(ctx, req)
Expand Down
3 changes: 2 additions & 1 deletion system-tests/tests/smoke/cre/v2_vault_don_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ func ExecuteVaultTest(t *testing.T, testEnv *ttypes.TestEnvironment) {
framework.L.Info().Msg("Waiting 30 seconds for the Vault DON to be ready...")
time.Sleep(30 * time.Second)
executeVaultSecretsCreateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
// disable get tests
// executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsUpdateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsListTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
executeVaultSecretsDeleteTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)
Expand Down
Loading