[CLD-281]: fix(cldf): remove chain fields on environment struct #17966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/cld-281/remove-chain-fields
branch
5 times, most recently
from
4463919 to
9ce3896
Compare
jkongie
previously approved these changes
Jun 2, 2025
giogam
previously approved these changes
Jun 2, 2025
DimitriosNaikopoulos
previously approved these changes
Jun 2, 2025
graham-chainlink
dismissed stale reviews from DimitriosNaikopoulos, giogam, and jkongie
via
10ee376
graham-chainlink
force-pushed
the
ggoh/cld-281/remove-chain-fields
branch
from
9ce3896 to
10ee376
Compare
graham-chainlink
requested review from
ilija42,
winder,
asoliman92,
matYang,
makramkd,
AmrMohamedRezk,
0xAustinWang and
0xnogo
jkongie
previously approved these changes
Jun 3, 2025
DimitriosNaikopoulos
previously approved these changes
Jun 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
fix(cldf): remove chain fields on environment struct There should be no more usage on these deprecated chain fields. All access should be via env.BlockChains.EVMChains() etc. JIRA: https://smartcontract-it.atlassian.net/browse/CLD-281
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
There should be no more usage on these deprecated chain fields. All access should be via env.BlockChains.EVMChains() etc. JIRA: https://smartcontract-it.atlassian.net/browse/CLD-281
graham-chainlink
dismissed stale reviews from DimitriosNaikopoulos and jkongie
via
b68de58
graham-chainlink
force-pushed
the
ggoh/cld-281/remove-chain-fields
branch
from
10ee376 to
b68de58
Compare
|
DimitriosNaikopoulos
approved these changes
Jun 3, 2025
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌5 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jkongie
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no more usage on these deprecated chain fields. All access should be via env.BlockChains.EVMChains() etc.
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-281