-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4420 Merging back CCIP codebase #15890
Draft
mateusz-sekara
wants to merge
1,599
commits into
develop
Choose a base branch
from
ccip-merge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+9,041
−762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add case for gnosis * add changeset * fix typo * typo --------- Co-authored-by: Prashant Yadav <[email protected]>
* add error handling for service unavailable for arbitrum * add changeset * update error message --------- Co-authored-by: Prashant Yadav <[email protected]>
## Motivation ## Solution
## Motivation getPreviousPool was missing ## Solution Add getPreviousPool
- NOTE ~5k is generated protobuf code to unblock. That will be imported once exposed. - We put the deployment/configuration logic in integration-tests module for a few reasons: - Keeps the chain dependencies out of the core module, in particular helpful for eventual cross family tests - It can become the canonical deployment logic to be used for CRIB envs as well (eventually can replace the actions + contracts dirs) - To accomplish the lightweight tests (chainlink.Application + simulated.Backend) we expose some test utilities in util/testutils/ - integration-tests/deployment holds product agnostic deployment utilities including a general purpose environment structure to write environment abstracted code against and migration output components (address books, proposals etc) - integration-tests/deployment/ccip holds all product specific deployment code including - Top level migrations and migration tests where a "migration" is defined to be a function which operates against an environment and outputs a MigrationOutput structure with one or more artifacts (MCMS proposals, job specs). Notably migration tests can apply those outputs to an ephemeral environment to ensure correctness. These migrations are intended for export and use against real environments (testnet/mainnet). - Re-usable product specific components of top level migrations and associated tests Next steps / follow up PRs: - Port testutils export to chainlink repo - Example solana setup - Once cross family validated, start deeper testing and real CCIP use cases --------- Co-authored-by: Adam Hamrick <[email protected]> Co-authored-by: AnieeG <[email protected]>
## Motivation Needed a script to update compiled json artifacts in G++ ## Solution Added few more options in solc compile Generated a shell script and make command to update artifacts in G++ path for specific contracts
## Motivation CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues ## Solution add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
#1310) ## Motivation gasUsed for Execution to be emitted along with ExecutionStateChangedEvent ## Solution compute `gasUsed` for execution of a message in EVM2EVMMultiOffRamp this change is applicable to only 1.6 version Test Assertion must be added to assert the event body parameters (excluding the gasUsed as it cant be hardcoded in tests) ** This is extension of the closed PR: smartcontractkit/ccip#1297 got signature verification issue with other PR. so moving all changes over here --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Ryan <[email protected]>
## Motivation Use the commit plugin state machine implementation. ## Solution Use the commit plugin state machine implementation.
Signed-off-by: chainchad <[email protected]>
## Motivation ## Solution
Cleanup & more realistic values for gas overheads
* No new finalized Heads Implementation * fixed tests * update defaults for NoNewFinalizedHeadsThreshold * Update common/client/node_lifecycle.go Co-authored-by: amit-momin <[email protected]> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <[email protected]> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <[email protected]> * rename HeadIsNotIncreasing to NoNewHead * move and add docs for syncIssue consts * rename syncIssue to syncStatus --------- Co-authored-by: amit-momin <[email protected]>
* allow to configure RPCTimeouts * Custom (30s) timeout for Hedera RPC requests with large payloads (SendTransaction, CallContext, etc.) * fix linter
* Added post-broadcast nonce validation for Hedera * Added changeset * Updated chaintype docs for Hedera * Fixed lint errors * Added condition to handle on-chain seq less than tx seq and updated comment
* Custom Astar finality * fix merge artifact * fix lint issue * simplify isRequestingFinalizedBlock * avoid iterating through the whole batch again * fix errors wrapping
Cherry pick of #14132 Co-authored-by: amit-momin <[email protected]>
…or-gnosis-and-arbitrum
…or-gnosis-and-arbitrum
## Motivation Want to be maximally defensive for the address book to prevent corruption. ## Solution - Type contract and version - Let products compose type and version at deploy/state gen time to avoid a combinatorial number of strings
## Motivation There were many transactions which needed to be executed. ## Solution Finish the work that @dimkouv started in #631 --------- Co-authored-by: Abdelrahman Soliman (Boda) <[email protected]>
mateusz-sekara
had a problem deploying
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Error
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:38 — with
GitHub Actions
Inactive
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:39 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:40 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:41 — with
GitHub Actions
Inactive
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:41 — with
GitHub Actions
Inactive
mateusz-sekara
force-pushed
the
ccip-merge
branch
from
January 10, 2025 15:42
9bacae8
to
40d7743
Compare
mateusz-sekara
temporarily deployed
to
integration
January 10, 2025 15:42 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the following directories:
core/services/ocr2/plugins/ccip
core/services/relay/evm
core/chains/evm
Using state from ccip repo at smartcontractkit/ccip@ecc1fb0
Merge was done using the following command