feat(keystone): add capabilities and add nops as mcms proposals #15887
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
MStreet3
force-pushed
the
cappl-344/configure-cap-reg
branch
from
b1c81ba to
c4e3e2a
Compare
MStreet3
force-pushed
the
cappl-344/configure-cap-reg
branch
from
c4e3e2a to
a1634a1
Compare
| if useMCMS { | ||
| txOpts = deployment.SimTransactOpts() | ||
| return addCapabilitiesMCMSProposal(registry, deduped, chain) |
There was a problem hiding this comment.
@MStreet3 Just fyi that I added some strategy helpers to handle MCMS in the workflow registry changesets I wrote:
Is this something that could be useful here to abstract away the complexity of MCMS?
There was a problem hiding this comment.
yes, these could be useful, I hadn't seen them until now. Taking a quick look, the biggest blocker to using them in this PR is that the legacy functions modified in this PR don't return deployment.ChangesetOutput. I wanted to avoid refactoring while changing the implementation. Adding the unit tests in this PR will make a refactor that changes signatures and uses these strategies simpler to verify.
Thoughts @krehermann
There was a problem hiding this comment.
A lot of this logic that's neatly tied into the strategies is currently repeated/split into chainlink-deployments. So really to use these strategies would clean up both repos.
There was a problem hiding this comment.
ticket to refactor for strategy https://smartcontract-it.atlassian.net/browse/CRE-109
MStreet3
dismissed stale reviews from cedric-cordenier and krehermann
via
c843e26
MStreet3
force-pushed
the
cappl-344/configure-cap-reg
branch
from
a1634a1 to
c843e26
Compare
|
the CapabilityRegistry for a chain is eventually transferred to a MCMS. this PR enables the creation of changesets that generate MCMS proposals for
AddNOPs,AddNodes,AddDONsandAddCapabilitiescalls.transaction data is generated using a simulated signer. unit tests are added yet scoped to just the MCMS proposal generation.
Requires
Supports