Right-pad workflow name if it is too short

[vreff]

Workflow names can be passed to the encoder as containing 7 bytes rather than 10; in this case they must be right-padded with zero bytes up to the required length.

See this logic enforced in the chain writer: https://github.com/smartcontractkit/chainlink/blob/develop/core/capabilities/targets/write_target.go#L206

[github-actions]

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[cedric-cordenier]

Hmmmm... not wild about this approach: the 10-byte limit is an issue that comes up again and again; I would suggest we handle this somewhere more central, like we do with the WorkflowRegistry

Eg. in the engine by modifying the WorkflowNamer implementation; the idea here is to handle this padding at the earliest part in the system rather than piecemeal in a few places.

I would recommend you also discuss any solution that touches the workflow engine with @krehermann as he's the lead on the Workflow Engine team

[vreff]

Hmmmm... not wild about this approach: the 10-byte limit is an issue that comes up again and again; I would suggest we handle this somewhere more central, like we do with the WorkflowRegistry

Eg. in the engine by modifying the WorkflowNamer implementation; the idea here is to handle this padding at the earliest part in the system rather than piecemeal in a few places.

I would recommend you also discuss any solution that touches the workflow engine with @krehermann as he's the lead on the Workflow Engine team

We're not in a huge rush to merge this, so I'll consult @krehermann on potentially handling this upstream first.