[DRAFT] Sol ccip messaging test

[smickovskid]

No description provided.

[cl-sonarqube-production]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (integration-tests) , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. Import error in utils.go:

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Source of Error:

Golang Lint (deployment)	2025-01-09T14:33:26.7467946Z ##[error]deployment/keystone/changeset/internal/test/utils.go:18:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
Golang Lint (deployment)	2025-01-09T14:33:26.7471982Z ##[error]environment/memory/environment.go:90:32: cannot use mchains (variable of type map[uint64]EVMChain) as Chains value in argument to generateMemoryChain
Golang Lint (deployment)	2025-01-09T14:33:26.7474108Z ##[error]environment/memory/environment.go:183:34: cannot use config.Chains (variable of type int) as NumChains value in argument to NewMemoryChains) (typecheck)

Why: The import statement for github.com/smartcontractkit/chainlink/deployment/environment/memory is causing issues because the types used in the environment.go file do not match the expected types in the function arguments.

Suggested fix: Ensure that the types of variables mchains and config.Chains match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

2. Import error in test_assertions.go:

Source of Error:

Golang Lint (deployment)	2025-01-09T14:33:26.7478241Z ##[error]deployment/ccip/changeset/test_assertions.go:21:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
Golang Lint (deployment)	2025-01-09T14:33:26.7481074Z ##[error]environment/memory/environment.go:90:32: cannot use mchains (variable of type map[uint64]EVMChain) as Chains value in argument to generateMemoryChain
Golang Lint (deployment)	2025-01-09T14:33:26.7483255Z ##[error]environment/memory/environment.go:183:34: cannot use config.Chains (variable of type int) as NumChains value in argument to NewMemoryChains) (typecheck)

Why: Similar to the previous error, the import statement for github.com/smartcontractkit/chainlink/deployment/environment/memory is causing issues due to type mismatches in the environment.go file.

Suggested fix: Ensure that the types of variables mchains and config.Chains match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

3. Import error in test_helpers.go:

Source of Error:

Golang Lint (deployment)	2025-01-09T14:33:26.7487180Z ##[error]deployment/ccip/changeset/v1_5/test_helpers.go:25:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
Golang Lint (deployment)	2025-01-09T14:33:26.7489557Z ##[error]environment/memory/environment.go:90:32: cannot use mchains (variable of type map[uint64]EVMChain) as Chains value in argument to generateMemoryChain
Golang Lint (deployment)	2025-01-09T14:33:26.7491756Z ##[error]environment/memory/environment.go:183:34: cannot use config.Chains (variable of type int) as NumChains value in argument to NewMemoryChains) (typecheck)

Why: The import statement for github.com/smartcontractkit/chainlink/deployment/environment/memory is causing issues due to type mismatches in the environment.go file.

Suggested fix: Ensure that the types of variables mchains and config.Chains match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

4. Unused variable config in set_config_mcms_test.go:

Source of Error:

Golang Lint (deployment)	2025-01-09T14:33:26.7496987Z ##[error]deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
Golang Lint (deployment)	2025-01-09T14:33:26.7495440Z 	config := proposalutils.SingleGroupTimelockConfig(t)

Why: The variable config is declared but not used in the set_config_mcms_test.go file.

Suggested fix: Either use the config variable in the test or remove its declaration if it is not needed.

5. Unused variable config in link_transfer_test.go:

Source of Error:

Golang Lint (deployment)	2025-01-09T14:33:26.7496987Z ##[error]deployment/common/changeset/example/link_transfer_test.go:36:2: declared and not used: config (typecheck)
Golang Lint (deployment)	2025-01-09T14:33:26.7497861Z 	config := proposalutils.SingleGroupMCMS(t)

Why: The variable config is declared but not used in the link_transfer_test.go file.

Suggested fix: Either use the config variable in the test or remove its declaration if it is not needed.

6. Import error in ccipreader_test.go:

Source of Error:

Golang Lint (integration-tests)	2025-01-09T14:33:58.5712751Z ##[error]integration-tests/contracts/ccipreader_test.go:26:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
Golang Lint (integration-tests)	2025-01-09T14:33:58.5716620Z ##[error]../deployment/environment/memory/environment.go:90:32: cannot use mchains (variable of type map[uint64]EVMChain) as Chains value in argument to generateMemoryChain
Golang Lint (integration-tests)	2025-01-09T14:33:58.5718851Z ##[error]../deployment/environment/memory/environment.go:183:34: cannot use config.Chains (variable of type int) as NumChains value in argument to NewMemoryChains) (typecheck)

Why: The import statement for github.com/smartcontractkit/chainlink/deployment/environment/memory is causing issues due to type mismatches in the environment.go file.

Suggested fix: Ensure that the types of variables mchains and config.Chains match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

7. Unused variable ownerChainB in ccip_usdc_test.go:

Source of Error:

Golang Lint (integration-tests)	2025-01-09T14:33:58.5721834Z ##[error]integration-tests/smoke/ccip/ccip_usdc_test.go:52:2: declared and not used: ownerChainB (typecheck)
Golang Lint (integration-tests)	2025-01-09T14:33:58.5722618Z 	ownerChainB := e.Chains[chainB].DeployerKey

Why: The variable ownerChainB is declared but not used in the ccip_usdc_test.go file.

Suggested fix: Either use the ownerChainB variable in the test or remove its declaration if it is not needed.

8. Type mismatch in environment.go:

Source of Error:

Run tests	2025-01-09T14:33:04.8112069Z ##[error]environment/memory/environment.go:90:32: cannot use mchains (variable of type map[uint64]EVMChain) as Chains value in argument to generateMemoryChain
Run tests	2025-01-09T14:33:04.8119555Z ##[error]environment/memory/environment.go:183:34: cannot use config.Chains (variable of type int) as NumChains value in argument to NewMemoryChains

Why: The types of variables mchains and config.Chains do not match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

Suggested fix: Ensure that the types of variables mchains and config.Chains match the expected types in the function arguments of generateMemoryChain and NewMemoryChains.

9. Test failure in go_core_tests:

Source of Error:

Run tests	2025-01-09T14:43:19.0479937Z FAIL
Run tests	2025-01-09T14:43:19.0480463Z FAIL	github.com/smartcontractkit/chainlink/v2/core/capabilities/remote/executable	633.022s
Run tests	2025-01-09T14:43:20.1213464Z FAIL

Why: The test suite for go_core_tests failed, indicating issues in the core/capabilities/remote/executable package.

Suggested fix: Investigate the specific test failures in the core/capabilities/remote/executable package and address the issues causing the tests to fail.