Conversation
|
👋 bolekk, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
| PerWorkflow Workflows `scope:"workflow"` | ||
| } | ||
| type Orgs struct { | ||
| FeatureFlags FeatureFlags |
There was a problem hiding this comment.
A simpler approach would be to just use Setting[time.Time] or similar (e.g. unix ts as int).
| FeatureFlags FeatureFlags | |
| FooBarEffectiveDate Setting[time.Time] |
This will essentially work without any other code changes. We could additionally add a new limiter data structure, maybe FeatureLimiter, which behaves like a Gate that understands the effective dates. This would be a little more intuitive to use since everything currently behaves as an upper bound, but these are effectively lower bounds. However, it is not strictly necessary, since you can get the value and do the basic enforcement of date comparison yourself.
2 participants
[DRAFT] feature flags