deployments: handle DisableFinalityCheckers config gen#622
Merged
Conversation
* Move the DisableFinalityCheckers override from GenerateConfigWithBlockchainInfos to the changeset that generates the committee verifier config. * The Canton override is still required due to the runtime hydration, moving this to the changesets would be a more significant refactor.
|
Code coverage report:
|
makramkd
commented
Jan 29, 2026
| github.com/smartcontractkit/chainlink-ccip/ccv/chains/evm v0.0.0-20260116110203-68d767f52164 | ||
| github.com/smartcontractkit/chainlink-ccip/ccv/chains/evm/deployment v0.0.0-20260116110203-68d767f52164 | ||
| github.com/smartcontractkit/chainlink-ccv v0.0.0-20260122132406-0ada7a3fe04a | ||
| github.com/smartcontractkit/chainlink-ccv v0.0.0-20260129103857-fe36763e89c2 |
Collaborator
Author
There was a problem hiding this comment.
This is irrelevant, we have a replace for chainlink-ccv
| github.com/smartcontractkit/chainlink-ccip/chains/evm/deployment v0.0.0-20260110001823-6248663ac9c4 | ||
| github.com/smartcontractkit/chainlink-ccip/deployment v0.0.0-20260113130254-8ce3b210bc66 | ||
| github.com/smartcontractkit/chainlink-ccv v0.0.0-20260116152026-295e4f116719 | ||
| github.com/smartcontractkit/chainlink-ccv v0.0.0-20260129103857-fe36763e89c2 |
Collaborator
Author
There was a problem hiding this comment.
Latest main as of writing.
mateusz-sekara
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #617
GenerateConfigWithBlockchainInfos to the changeset that generates the
committee verifier config.
moving this to the changesets would be a more significant refactor.