Disable Pharo in CI and fix Rubocop #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
The following stack trace is reported:
```
Error: Can't find the requested origin
UnixResolver(PlatformResolver)>>cantFindOriginError
[ self cantFindOriginError ] in UnixResolver(PlatformResolver)>>directoryFromEnvVariableNamed: in Block: [ self cantFindOriginError ]
UnixResolver(PlatformResolver)>>directoryFromEnvVariableNamed:or:
UnixResolver(PlatformResolver)>>directoryFromEnvVariableNamed:
UnixResolver>>home
```
But since we still have Squeak, which seems to work, I’ll disable Pharo for the moment.
Signed-off-by: Stefan Marr <[email protected]>
|
The Pharo issue with |
|
Instead of disabling Pharo, I guess you could use Pharo64-11 or so? |
|
The key is really making sure Still need to figure out how to make this work on both Squeak and Pharo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pharo is currently failing with the following stack trace:
The following stack trace is reported:
See for instance: https://github.com/smarr/are-we-fast-yet/actions/runs/7492188644/job/20395161374#step:17:30
If anyone knows what this might be, PRs are welcome. (Sorry for the ping, just in case someone has a thought: @guillep, @tesonep, @clementbera, @fniephaus)
But since we still have Squeak, which seems to work, I’ll disable Pharo for the moment, which is my quickest way to get the CI green... sorry.