The #= on Symbol and String should be symmetric

- it’s only defined in String - there’s no hint that it should behave differently in Symbol which is a subclass - so, we really should just consider the string content when comparing #foobar = ‘foobar’ Signed-off-by: Stefan Marr <[email protected]>
smarr · Jan 13, 2023 · afe38e8 · afe38e8 · rebenchdb · Jan 13, 2023
1 parent 5f52eef
commit afe38e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core-lib b/core-lib
diff --git a/src/som/primitives/SymbolPrimitives.js b/src/som/primitives/SymbolPrimitives.js
@@ -24,6 +24,7 @@
 import { Primitives } from './Primitives.js';
 
 import { universe } from '../vm/Universe.js';
+import { SString } from '../vmobjects/SString.js';
 
 function _asString(_frame, args) {
   return universe.newString(args[0].getString());
@@ -35,6 +36,10 @@ function _equals(_frame, args) {
   if (op1 === op2) {
     return universe.trueObject;
   }
+
+  if (op1 instanceof SString && op1.getEmbeddedString() === op2.getEmbeddedString()) {
+    return universe.trueObject;
+  }
   return universe.falseObject;
 }
+10 −10		.github/workflows/ci.yml
+5 −5		Examples/Benchmarks/TestSuite/Symbol2Test.som
+5 −5		Examples/Benchmarks/TestSuite/Symbol3Test.som
+5 −5		Examples/Benchmarks/TestSuite/Symbol4Test.som
+5 −5		Examples/Benchmarks/TestSuite/Symbol5Test.som
+5 −5		Examples/Benchmarks/TestSuite/SymbolTest.som
+4 −2		Smalltalk/Symbol.som
+0 −8		SomSom/src/primitives/SymbolPrimitives.som
+6 −1		TestSuite/SymbolTest.som