-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Allow loading cases for tests.py #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@smarie Please, review this. |
Hi @last-partizan , I looked at your PR and slightly improved it. Now my problem is that the test does not seem to run at all :) Could it be that this correspond to an old behaviour from pytest ? Maybe pytest does not run anymore a collected file that is named |
Yes. It seems to be the case.
I think pytest never collected
|
@@ -87,6 +87,7 @@ test = pytest | |||
# pytest default configuration | |||
[tool:pytest] | |||
testpaths = tests/ | |||
python_files = tests.py test_*.py *_tests.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added same config option here, if that's okay.
Fixes #366
Hi, i noticed that after updating to 3.8.5 this package stopped loading cases from tests_cases.py.
This PR fixes it.
Can this be accepted? Or it's better for me to rename my
tests.py
totest_something.py
?