fix(agentgateway): port #230 quality fixes + Nicole review onto smahr/main#1
Merged
Merged
Conversation
Author
|
Opened on the wrong repository; will open on SAP/cloud-sdk-python instead. |
Include sdk-review quality findings and Nicole review cleanup that were previously landed on the wrong SAP branch (feat/transparent-tls-smahr).
tiagoek
force-pushed
the
fix/pr-220-nicole-on-smahr
branch
from
July 17, 2026 17:15
917bc3c to
85f1e0d
Compare
NicoleMGomes
approved these changes
Jul 17, 2026
tiagoek
marked this pull request as ready for review
July 17, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports onto
smahr/main(PR SAP#220) the work that was incorrectly merged intofeat/transparent-tls-smahr:From SAP#230 (sdk-review quality)
_TOKEN_FIELD_CLIENT_ID/_TOKEN_FIELD_ACCESS_TOKENconstants in_customer.py_LOG_TRANSPARENT_MODEconstant inagw_client.pyraise ... from eon token requesthttpx.RequestErrorhandlersFrom SAP#234 / Nicole review
src/sap_cloud_sdk/core/_telemetry_compat.pyand restorecore.telemetryimportstests/agentgateway/unit/test_lob.pyVersion left at
0.34.0(already onsmahr/main).Related Issue
Follow-up for SAP#220
Type of Change
How to Test
_telemetry_compat.pyis gonetest_lob.pyimports match pre-noise layoutChecklist
Breaking Changes
None.