Skip to content

fix(agentgateway): port #230 quality fixes + Nicole review onto smahr/main#1

Merged
smahr merged 1 commit into
smahr:mainfrom
SAP:fix/pr-220-nicole-on-smahr
Jul 17, 2026
Merged

fix(agentgateway): port #230 quality fixes + Nicole review onto smahr/main#1
smahr merged 1 commit into
smahr:mainfrom
SAP:fix/pr-220-nicole-on-smahr

Conversation

@tiagoek

@tiagoek tiagoek commented Jul 17, 2026

Copy link
Copy Markdown

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

Ports onto smahr/main (PR SAP#220) the work that was incorrectly merged into feat/transparent-tls-smahr:

From SAP#230 (sdk-review quality)

  • _TOKEN_FIELD_CLIENT_ID / _TOKEN_FIELD_ACCESS_TOKEN constants in _customer.py
  • _LOG_TRANSPARENT_MODE constant in agw_client.py
  • raise ... from e on token request httpx.RequestError handlers

From SAP#234 / Nicole review

  • Remove src/sap_cloud_sdk/core/_telemetry_compat.py and restore core.telemetry imports
  • Revert unnecessary change in tests/agentgateway/unit/test_lob.py

Version left at 0.34.0 (already on smahr/main).

Related Issue

Follow-up for SAP#220

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Code refactoring

How to Test

  1. Confirm _telemetry_compat.py is gone
  2. Confirm token field / log constants from fix(agentgateway): address sdk-review quality findings from PR #220 SAP/cloud-sdk-python#230 are present
  3. Confirm test_lob.py imports match pre-noise layout

Checklist

Breaking Changes

None.

@tiagoek

tiagoek commented Jul 17, 2026

Copy link
Copy Markdown
Author

Opened on the wrong repository; will open on SAP/cloud-sdk-python instead.

@tiagoek tiagoek closed this Jul 17, 2026
@tiagoek tiagoek reopened this Jul 17, 2026
Include sdk-review quality findings and Nicole review cleanup that were
previously landed on the wrong SAP branch (feat/transparent-tls-smahr).
@tiagoek
tiagoek force-pushed the fix/pr-220-nicole-on-smahr branch from 917bc3c to 85f1e0d Compare July 17, 2026 17:15
@tiagoek tiagoek changed the title fix(agentgateway): remove telemetry compat and revert test_lob noise fix(agentgateway): port #230 quality fixes + Nicole review onto smahr/main Jul 17, 2026
@tiagoek
tiagoek marked this pull request as ready for review July 17, 2026 17:36
@smahr
smahr merged commit 5d9742a into smahr:main Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants