Skip to content

Gate defmt behind target_os="none" #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paul-fornage
Copy link
Contributor

Does what it says.

You can always include the defmt feature, but it won't do anything unless you are running on bare metal. As far as I can tell there is no better solution.

@paul-fornage
Copy link
Contributor Author

I have another PR that depends on this one that will entirely replace the log crate with defmt, instead of just adding defmt derives. That one is living in my master branch if you want to just skip straight to that let me know, it's ready to go. It is possible to use the existing log statements in embedded already with log-to-defmt, but that is very inefficient and should only be used in development if you even have the overhead available.

@flosse
Copy link
Member

flosse commented Jul 1, 2025

In general that sounds good ☺️ Unfortunately, I won't be able to look into it until the middle/end of August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants