Add first end2end test using Spectron #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciobarrios
approved these changes
Apr 20, 2017
spec/features/global-helpers.js
Outdated
| }); | ||
|
|
||
| const stopApp = app => { | ||
| return app && app.isRunning() && app.stop(); |
There was a problem hiding this comment.
If you feel fancy:
const stopApp = app => app && app.isRunning() && app.stop();
|
@marciobarrios comment fixed! Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a first end2end test using Spectron.
I will add more tests in an upcoming PR.
Motivation and Context
No tests, no party
Related to issue #10
How Has This Been Tested?
It's actually the first test 💃 🕺
Screenshots (if appropriate):
Types of changes
Checklist: