Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect argument from the TerminalRenderer render small test #7

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jozefizso
Copy link
Member

This PR is a back-port for the soldair#381

The test TerminalRenderer render small calls the t.equal() function with an additional argument which should not be there.

Running this test with tap@20 will result in a failed test:

TerminalRenderer render small > Cannot create property 'bail' on string 'Should call a callback'
 FAIL  test/unit/renderer/terminal.test.js 1 failed of 11 1.483s
 ✖  TerminalRenderer render small > Cannot create property 'bail' on string 'Should call a callback'
    test/unit/renderer/terminal.test.js                                               
    65   t.type(str, 'string',                                                        
    66     'Should return a string')                                                  
    67                                                                                
    68   t.equal(calledCallback, true, 'string',                                      
    ━━━━━━━┛                                                                          
    69     'Should call a callback')                                                  
    70                                                                                
    71   t.doesNotThrow(function () {                                                 
    72     str = TerminalRenderer.render(sampleQrData, { small: true, inverse: true })
    type: TypeError
    tapCaught: testFunctionThrow
    Test.<anonymous> (test/unit/renderer/terminal.test.js:68:5)

@jozefizso jozefizso requested a review from DominikPalo October 14, 2024 09:30
@jozefizso jozefizso self-assigned this Oct 14, 2024
@jozefizso jozefizso added bug Something isn't working tests labels Oct 14, 2024
@jozefizso jozefizso added this to the v2.0.0 milestone Oct 14, 2024
@jozefizso jozefizso merged commit ad29898 into main Oct 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants