Fix MSAL silent errors

sleepyfran · Aug 27, 2024 · 7a30195 · 7a30195
1 parent f2db7ec
commit 7a30195
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/infrastructure/onedrive-provider/src/msal-authentication.ts b/packages/infrastructure/onedrive-provider/src/msal-authentication.ts
@@ -36,6 +36,11 @@ export const MsalAuthenticationLive = Layer.effect(
           clientId: appConfig.graph.clientId,
           redirectUri: appConfig.graph.redirectUri,
         },
+        cache: {
+          cacheLocation: "localStorage",
+          temporaryCacheLocation: "sessionStorage",
+          storeAuthStateInCookie: true,
+        },
       }),
     );
 
@@ -67,7 +72,7 @@ export const MsalAuthenticationLive = Layer.effect(
       });
 
       const authResult = yield* Effect.tryPromise({
-        try: () => app.loginPopup(authRequest),
+        try: () => app.acquireTokenPopup(authRequest),
         catch: () => AuthenticationError.Unknown,
       });
 
@@ -79,6 +84,9 @@ export const MsalAuthenticationLive = Layer.effect(
         const app = yield* msalAppRef.get;
 
         if (cachedCredentials.providerSpecific._tag !== "MSAL") {
+          yield* Effect.logError(
+            "Cached credentials are not MSAL-specific, cannot connect silently",
+          );
           return yield* Effect.fail(AuthenticationError.WrongCredentials);
         }
 
@@ -100,6 +108,11 @@ export const MsalAuthenticationLive = Layer.effect(
               : AuthenticationError.Unknown;
           },
         }).pipe(
+          Effect.tap((authInfo) =>
+            Effect.log(
+              `Successfully connected silently using MSAL, new token expiration ${authInfo.expiresOn}`,
+            ),
+          ),
           Effect.tapError((e) =>
             Effect.logError(`Error while connecting silently: ${e}`),
           ),

diff --git a/packages/services/app-init/src/app-init.ts b/packages/services/app-init/src/app-init.ts
@@ -30,6 +30,10 @@ const make = Effect.gen(function* () {
     init: Effect.gen(function* () {
       const allProviderStates = yield* retrieveAllProviderArgs(localStorage);
 
+      yield* Effect.log(
+        `Re-initializing ${allProviderStates.length} providers on startup`,
+      );
+
       return yield* Effect.all(
         allProviderStates.map((providerStartArgs) =>
           Effect.gen(function* () {