-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #7. There were quite a few problems with the implementation, namely: - The player listeners were not properly being set because the `consumeCommandsInBackground` was called before setting up listeners without forking the effect into another fiber, essentially not calling the setup of the listeners until that effect was done (which was never). - Even if the listeners were properly setup, since we were exposing the raw queue in the `observe` function, the subscribers of the stream would only get whichever event were currently in the queue and then the stream would close. This was fixed by casting the queue to a stream. - And even after all the previous problems were fixed, the listener setup was not done correctly and we were not correctly handling `play` updates or tracks finishing.
1 parent
66a1065
commit 10e89eb
Showing
1 changed file
with
27 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters