Implement auto_acknowledge feature for socket clients. - #1300
Closed
amshamah419 wants to merge 4 commits into
Closed
amshamah419 wants to merge 4 commits into
amshamah419 wants to merge 4 commits into
Conversation
seratch
marked this pull request as draft
November 14, 2022 22:19
Contributor
|
Hi @amshamah419, thanks for sending this! But for the reasons that I mentioned at #1299 (comment), we would like to hold off working on the details of this PR at this moment. |
Contributor
|
Thanks again for sending this PR! but for the reason I mentioned above, we are not planning to add this flag at least in the short term. So, let us close this issue now. It'd be appreciated if you could understand this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal is to allow the Socket Mode Client to automatically send the acknowledgment notification to reduce the likelihood that a message could expire while waiting in the event queue.
The default is currently
Falseto prevent any backwards compatibility issues.fixes: #1299
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.