feat: add has_been_called on complete & fail utility#1390
Merged
WilliamBergamin merged 1 commit intomainfrom Oct 10, 2025
Merged
feat: add has_been_called on complete & fail utility#1390WilliamBergamin merged 1 commit intomainfrom
complete & fail utility#1390WilliamBergamin merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 91.03% 91.05% +0.02%
==========================================
Files 222 222
Lines 7514 7534 +20
==========================================
+ Hits 6840 6860 +20
Misses 674 674 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Oct 10, 2025
Member
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM! This is quite slick I admit 🚢 💨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes allow to easily determine if
failorcompletewas invoked, invoking both in the same handler can sometimes lead to errors returned from the Slack APITesting
The same applies to the
failutility function 🙏Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.