build: require cheroot<11 with adapter test dependencies#1375
Conversation
| boto3<=2 | ||
| bottle>=0.12,<1 | ||
| chalice>=1.28,<2; | ||
| cheroot<11 # https://github.com/slackapi/bolt-python/issues/1374 |
There was a problem hiding this comment.
praise: Thanks for linking the issue so we know why we're requiring a lower version of cheroot. Let's hope this works on the CI side as well! 🤞🏻
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 222 222
Lines 7512 7512
=======================================
Hits 6836 6836
Misses 676 676 ☔ View full report in Codecov by Sentry. |
|
@mwbrooks I'm so glad we narrowed this down to a version update too! 🔏 Let's merge this now to follow up on the linked issue. I also agree that this isn't an ideal fix but perhaps revisiting this in a change upstream might resolve things? Let's discuss in issue! 🧪 ✨ |
Summary
This PR has a workaround for #1374 to use
cheroot<11in adapter tests.Testing
Works on my machine and I hope CI now too. Huge kind thanks to @WilliamBergamin for helping me fix my test running setups! 🙏 ✨
Notes
I don't believe we should close the linked issue with this, but was wanting to unblock CI for ongoing finding! 🔍
Category
slack_bolt.adapterRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.