build(deps): remove pytest lower bounds from testing requirements#1333
build(deps): remove pytest lower bounds from testing requirements#1333
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 222 222
Lines 7512 7512
=======================================
Hits 6836 6836
Misses 676 676 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice work 💯
Just want to point out that we still officially support 3.6, but if we merge this change we may have issues testing with 3.6 locally, so we should drop official support for it in our next release
Other lower bound requirements are also present specifically for 3.6 it may be worth looking into them
|
@WilliamBergamin @ewanek1 Thank y'all both for the reviews!
This is a great callout that caused me to hold off on merging this for now - I'm not aware of the other changes needed to drop official If this can merge as is I think that'd be ideal, but please let me know if we should hold off more 🤖 |
|
@WilliamBergamin @ewanek1 Once again I appreciate the notice and reviews. I've added this to a milestone so we can keep track of which version we removed this bounds in 🎁 |
Summary
This PR removes the lower bounds of
pytestfollowing discussion in #1328 to support active versions 🚢 💨Testing
🤖 In
ciruns to follow.Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.