test: fix broken tests due to wild card import#1240
Merged
WilliamBergamin merged 1 commit intoslackapi:mainfrom Jan 29, 2025
Merged
test: fix broken tests due to wild card import#1240WilliamBergamin merged 1 commit intoslackapi:mainfrom
WilliamBergamin merged 1 commit intoslackapi:mainfrom
Conversation
WilliamBergamin
added
area:async
area:adapter
dependencies
WilliamBergamin
commented
Jan 29, 2025
| runs-on: ubuntu-20.04 | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| fail-fast: false |
Contributor
Author
There was a problem hiding this comment.
This is to allow maintainers to easily tell what versions of python may be affected by failing CI tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
commented
Jan 29, 2025
| sanic>=21,<24; python_version>"3.6" and python_version<="3.8" | ||
| sanic>=21,<25; python_version>"3.8" | ||
| starlette>=0.14,<1 | ||
| starlette>=0.19.1,<1 |
Contributor
Author
There was a problem hiding this comment.
starlette 0.19.1 is the latest version of this package that supports python 3.6
mwbrooks
approved these changes
Jan 29, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ LGTM! Thanks for the review comments as well! 🙇🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unit tests of #1239 are failing due to wild card imports of adapter dependencies, this PR aims to update the unit tests to allow them to pass with the changes introduced to dependencies
Testing
Run the unit tests
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.