Fix #1204 Deprecation Warnings in Slack Bolt Integration with Sanic#1220
Fix #1204 Deprecation Warnings in Slack Bolt Integration with Sanic#1220HTSagara wants to merge 3 commits intoslackapi:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
+ Coverage 90.94% 90.96% +0.02%
==========================================
Files 222 222
Lines 7506 7501 -5
==========================================
- Hits 6826 6823 -3
+ Misses 680 678 -2 ☔ View full report in Codecov by Sentry. |
|
@HTSagara Thanks for submitting this PR! 🙌 I see that your base branch is out of date with |
|
@hello-ashleyintech thank you for the feedback. I just updated my branch with the |
|
@HTSagara Thank you so much for taking the time to make these changes! I've added a few additional changes (= removed the comments repeating what the code does, added assertions in the Sanic unit tests to verify the cookie data behavior) and merged your changes as a single commit: 35a4b09 Thanks again for your contribution! 🎉 |
This Pull Request addresses #1204 deprecation warnings and type-related errors that occur when integrating Slack Bolt with Sanic. The warnings were caused by the use of Sanic's outdated dict-based cookie handling syntax, which has been deprecated since Sanic v23.3. These issues surfaced during testing and when handling requests.
Key Changes:
**Updated Cookie Handling: **
Resolved Type Errors:
Testing:
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.