Update DNS module and DNSResolver behaviour #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a warning while generating docs for 1.0.0. The
:inet.ip()
type thatDNSResolver
was referencing did not exist. I could not find at what point this type existed in Erlang, butDNS
library did use it inDNS.resolve/4
spec in version 2.2.0. Since then 2 versions have been released and the return type settled as{:ok, list()} | {:error, :inet_res.res_error()}
in 2.4.0This PR bumps
DNS
dependency to~2.4
and changesSafeURL.DNSResolver
behaviour to follow new spec.