Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DNS module and DNSResolver behaviour #14

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update DNS module and DNSResolver behaviour #14

merged 1 commit into from
Jan 15, 2025

Conversation

martosaur
Copy link
Member

I ran into a warning while generating docs for 1.0.0. The :inet.ip() type that DNSResolver was referencing did not exist. I could not find at what point this type existed in Erlang, but DNS library did use it in DNS.resolve/4 spec in version 2.2.0. Since then 2 versions have been released and the return type settled as {:ok, list()} | {:error, :inet_res.res_error()} in 2.4.0

This PR bumps DNS dependency to ~2.4 and changes SafeURL.DNSResolver behaviour to follow new spec.

@martosaur martosaur requested a review from jhchen January 10, 2025 19:11
@martosaur martosaur merged commit ce1aa51 into main Jan 15, 2025
2 checks passed
@martosaur martosaur deleted the am/bump_dns branch January 15, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants