Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update airspace files to more recent versions #663

Merged

Conversation

GliderGeek
Copy link
Contributor

This pull request updates the airspace files to the most recent versions found on soaringweb.org.

This changeset encompasses:
Germany, Belgium, France, Netherlands, Switzerland, Spain, Poland, Norway, Denmark, Finland

most are updated to 2017

This pull request closes #639, closes #381, closes #435

nl openair http://www.gliderpilotshop.nl/documents/EHv14_5.txt
be openair http://soaringweb.org/Airspace/BE/BELLUX_WEEK_170325b.txt
fr openair http://soaringweb.org/Airspace/FR/170529__AIRSPACE_FRANCE_1705.txt
nl http://soaringweb.org/Airspace/NL/EHv17_3.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like openair got removed here by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is correct, will fix that in separate commit

@GliderGeek
Copy link
Contributor Author

GliderGeek commented Jun 24, 2017

Can someone help out on checking whether these new airspace files are handled correctly?
I currently dont have a local installation on which this can be tested.

From @TobiasLohner in #538:

There are a few things to consider when updating airspaces:

  • Some of the airspace files contain unknown or wrong airspace class identifiers. This could possibly clutter the map when rendering (e.g. a FIR denoted as class A)
  • SkyLines uses the gdal/ogr openair/sua parser which is not as robust as XCSoar's. Some files need manual editing before importing.
  • Some airspace files contain country borders which shouldn't be imported as well. See https://github.com/skylines-project/skylines/blob/master/mapserver/airspace/airspace_blacklist.txt for some examples. This needs manual checking before import.

I recommend to test every single new airspace flie on a QA system (e.g. your local SkyLines installation).

@Turbo87
Copy link
Member

Turbo87 commented Jul 5, 2017

Can someone help out on checking whether these new airspace files are handled correctly?
I currently dont have a local installation on which this can be tested.

unfortunately I don't have the airspace rendering code setup locally either which is why I haven't merged this yet... 😞

@Turbo87 Turbo87 dismissed their stale review July 5, 2017 07:06

filetype was restored

@niggli
Copy link

niggli commented Nov 30, 2017

French link is already broken again, current one is http://soaringweb.org/Airspace/FR/170922__AIRSPACE_France_2017-08-17.txt

GliderGeek and others added 3 commits April 1, 2018 14:20
Germany, Belgium, France, Netherlands, Switzerland, Spain, Poland, Norway, Denmark, Finland
@Turbo87 Turbo87 force-pushed the airspace-updates-june-2017 branch from 85e7ccb to 837aed5 Compare April 1, 2018 15:34
@Turbo87
Copy link
Member

Turbo87 commented Apr 1, 2018

Finally managed to get this done! 🎉

I've updated some more airspaces and rebased/updated the PR :)

@Turbo87 Turbo87 merged commit ad1f4d3 into skylines-project:master Apr 1, 2018
@GliderGeek
Copy link
Contributor Author

Awesome stuff @Turbo87! Did you get the mapserver running locally?

@GliderGeek GliderGeek deleted the airspace-updates-june-2017 branch April 1, 2018 21:16
@Turbo87
Copy link
Member

Turbo87 commented Apr 2, 2018

Nope, but I broke prod for a few hours 🙈

@GliderGeek
Copy link
Contributor Author

ouch. any idea how we could get this thing working / ask someone who can guide us in the right direction?

@Turbo87
Copy link
Member

Turbo87 commented Apr 2, 2018

The thing that broke was actually not related to the airspace (except for Belgium), it was some MapServer update that broke the airfield rendering (see #770)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

outdated airspace airspace data needs update Update Dutch airspace for 2015
3 participants