Work around games closing standard handles on Windows #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some game libraries (admittedly, old ones) are linked against CRTDLL.DLL, which seems to close the standard handles on shutdown, breaking the system console if running a dedicated server. Work around this by stowing away the original standard input handles and working on duplicates, and attempt to re-duplicate the handles on certain errors.
|
Can you provide an example of a mod which does this? |
|
I noticed this this with "action", as shipped with Quake 2 Quad Damage on GOG. I don't remember what I did exactly, but the issue can be reproduced when a game DLL unload is triggered, eg by switching the game:
|
|
I think I might have triggered the issue while playing around with MVDs. There's a code path that calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some game libraries (admittedly, old ones) are linked against CRTDLL.DLL, which seems to close the standard handles on shutdown, breaking the system console if running a dedicated server.
Work around this by stowing away the original standard input handles and working on duplicates, and attempt to re-duplicate the handles on certain errors.