Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q2pro.desktop update, better icon, include metainfo for packaging #256

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fishxz
Copy link

@fishxz fishxz commented Aug 21, 2022

the dekstop file update allows to connect to server via q2servers.com

i think the metainfo needs some edit, especially the screenshots i used.

@fishxz fishxz changed the title Update q2pro.desktop q2pro.desktop update, better icon, include metainfo for packaging Aug 21, 2022
@skullernet
Copy link
Owner

This metainfo.xml is some Flatpak-specific thing, right? Why does it have to belong to Q2PRO repository?

The logo looks nice, however the fact that it's Yamagi Q2 logo with changed color concerns me. It doesn't seem fair to just rip off another project logo like that.

q2pro.desktop change is probably useful.

@fishxz
Copy link
Author

fishxz commented Aug 26, 2022

This metainfo.xml is some Flatpak-specific thing, right? Why does it have to belong to Q2PRO repository?

no. it has nothing to do with flatpak itself... its for packaging in general and providing infos for software centers.
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html

it seems to be the usual way to provide this upstream (just 3 big projects as an example):
https://github.com/xbmc/xbmc/blob/master/tools/Linux/kodi.metainfo.xml.in
https://github.com/obsproject/obs-studio/blob/master/UI/xdg-data/com.obsproject.Studio.appdata.xml.in
https://github.com/libretro/RetroArch/blob/master/com.libretro.RetroArch.appdata.xml

The logo looks nice, however the fact that it's Yamagi Q2 logo with changed color concerns me. It doesn't seem fair to just rip off another project logo like that.

i understand, but doesnt the license allow that? so i dont rly see how its just a rip off.
maybe provide the windows icon in high res (if its even available in such a resolution).

@carlossless carlossless mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants