MNT Fix CI issue from new scikit-learn==1.8.0#503
Merged
adrinjalali merged 15 commits intoskops-dev:mainfrom Jan 5, 2026
Merged
MNT Fix CI issue from new scikit-learn==1.8.0#503adrinjalali merged 15 commits intoskops-dev:mainfrom
adrinjalali merged 15 commits intoskops-dev:mainfrom
Conversation
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Member
|
Catboost seems failing, they're infamously slow to release for new dependencies, you can ignore them for now for this CI with a todo ideally pointing to an existing issue (or one you'd create) on the catboost repo. |
Contributor
Author
|
Member
|
The fetch california housing issue seems to be what we have in scikit-learn too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #502
What does this implement/fix? Explain your changes.
the issue stems from the change here - prior to sklearn 1.8 the collinearity case in QDA was a warning, now (in 1.8) it's an error. The warnings were not seen as they are supressed by the skops test setup.
Additions: