Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 account #21

Merged
merged 7 commits into from
Apr 23, 2024
Merged

19 account #21

merged 7 commits into from
Apr 23, 2024

Conversation

sroertgen
Copy link
Contributor

This PR adds login options for providing an account using wikimedia or orcid oauth.

@sroertgen sroertgen self-assigned this Mar 11, 2024
@sroertgen sroertgen linked an issue Mar 11, 2024 that may be closed by this pull request
@sroertgen
Copy link
Contributor Author

@Phu2 Please deploy to test system.

@Phu2
Copy link
Contributor

Phu2 commented Mar 25, 2024

Deployed to test.

@Phu2 Phu2 removed their assignment Mar 25, 2024
@acka47
Copy link
Member

acka47 commented Apr 10, 2024

Is this the latest status at https://reconcile-publish-test.skohub.io/?If yes, then the logos are missing, at least the Wikimedia one. I looged in with my Wikimedia account and it looks like this:

image

@sroertgen
Copy link
Contributor Author

Tried reloading? They are there for me...

image

@sroertgen
Copy link
Contributor Author

ah, you mean after the login. There is no logo currently shown. I will add one.

@sroertgen
Copy link
Contributor Author

@Phu2 Please redeploy to test system.

@sroertgen sroertgen assigned sroertgen and Phu2 and unassigned sroertgen Apr 22, 2024
@Phu2
Copy link
Contributor

Phu2 commented Apr 22, 2024

Deployed https://reconcile-publish-test.skohub.io/

@sroertgen
Copy link
Contributor Author

@acka47 I implemented changes as requested. Please have a look at the login again

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I could not test ORCID, though, as I do not have an account on the sandbox.

@sroertgen sroertgen merged commit c0ad87d into main Apr 23, 2024
1 check passed
@sroertgen sroertgen deleted the 19-account branch April 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer alternatives for providing an account
3 participants