Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Upload by URL feature #17

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add Upload by URL feature #17

merged 2 commits into from
Jan 31, 2024

Conversation

sroertgen
Copy link
Contributor

Adds the feature to provide a URL to a turtle file to upload to reconciliation service as requested in #16

@Phu2 Please deploy to test system for functional review.

@sroertgen sroertgen linked an issue Jan 22, 2024 that may be closed by this pull request
Support upload by URL #16
Closed
@Phu2
Copy link
Contributor

Phu2 commented Jan 22, 2024

Deployed to https://reconcile-publish-test.skohub.io/

@Phu2 Phu2 requested a review from acka47 January 22, 2024 14:16
@sroertgen
Copy link
Contributor Author

@acka47 feel free to test

https://reconcile-publish-test.skohub.io/

@sroertgen sroertgen assigned acka47 and unassigned Phu2 Jan 23, 2024
acka47
acka47 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. +1

Re. the example given in parentheses: I am not sure whether we need this but it might help some people in figuring out that the service does.

@acka47 acka47 removed their assignment Jan 29, 2024
@sroertgen sroertgen merged commit 64a9084 into main Jan 31, 2024
1 check passed
@sroertgen sroertgen deleted the 16-upload-by-url branch January 31, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acka47 acka47 acka47 approved these changes

Assignees

@sroertgen sroertgen

Labels
None yet
Projects
SkoHub
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support upload by URL
3 participants
@sroertgen @Phu2 @acka47