Update to ESLint 10 and align with sitespeed.io's ESLint stack#175
Merged
Conversation
Brings coach-core onto the same ESLint 10 baseline as sitespeed.io and
browsertime: eslint 9.17 → 10.4, eslint-config-prettier 9.1 → 10.1.8,
eslint-plugin-prettier 5.2 → 5.5.5. @eslint/js and globals were silently
transitive under v9 and are now declared explicitly, since the flat
config imports them directly.
While there, the config dropped FlatCompat in favour of the flat-config
shape ESLint 10 expects natively — js.configs.recommended is referenced
directly, which lets the @eslint/eslintrc dependency go.
ESLint 10 ships two new eslint:recommended rules (no-useless-assignment
and preserve-caught-error) that surfaced six findings, all fixed in
place rather than disabled. Five were let foo = '' initializers where
every subsequent code path reassigns before reading; they become
let foo;. The sixth was a rethrow in the wappalyzer engine that lost
the original error — adding { cause: error } preserves the chain.
Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings coach-core onto the same ESLint 10 baseline as sitespeed.io and
browsertime: eslint 9.17 → 10.4, eslint-config-prettier 9.1 → 10.1.8,
eslint-plugin-prettier 5.2 → 5.5.5. @eslint/js and globals were silently
transitive under v9 and are now declared explicitly, since the flat
config imports them directly.
While there, the config dropped FlatCompat in favour of the flat-config
shape ESLint 10 expects natively — js.configs.recommended is referenced
directly, which lets the @eslint/eslintrc dependency go.
ESLint 10 ships two new eslint:recommended rules (no-useless-assignment
and preserve-caught-error) that surfaced six findings, all fixed in
place rather than disabled. Five were let foo = '' initializers where
every subsequent code path reassigns before reading; they become
let foo;. The sixth was a rethrow in the wappalyzer engine that lost
the original error — adding { cause: error } preserves the chain.
Co-authored-by: Claude noreply@anthropic.com