Backfill HAR tests for the privacy, bestpractice and info rules#172
Merged
Conversation
Eleven of fourteen HAR privacy rules were shipping without a safety net, plus the HAR-level avoidRenderBlocking and the third-party rules in bestpractice / info. The header-based rules (cross-origin-*-policy, NEL, Reporting-Endpoints, Permissions-Policy, X-Content-Type-Options) each get a negative case against an existing fixture and a positive case built by cloning the fixture and pushing the target header on the document response — the same pattern technologyTest already used inline. The reCAPTCHA and mixed-content rules clone a fixture and inject a matching asset to exercise the positive path. bestpractice / info. The header-based rules (cross-origin-*-policy, NEL, Reporting-Endpoints, Permissions-Policy, X-Content-Type-Options) each get a negative case against an existing fixture and a positive case built by cloning the fixture and pushing the target header on the document response — the same pattern technologyTest already used inline. The reCAPTCHA and mixed-content rules clone a fixture and inject a matching asset to exercise the positive path. The third-party rules (privacy/thirdPartyPrivacy, bestpractice/thirdParty, info/thirdParty) lean on the existing http://www.nytimes.com.har fixture with the firstParty option set so pagexray classifies the off-domain assets correctly — that fixture has real surveillance-categorised tracking and exercises the score=0 branch end-to-end. A small firstAdviceForHar(har, options) helper was added to test/help/har.js so the clone-and-run pattern doesn't need to be copied around the new tests. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eleven of fourteen HAR privacy rules were shipping without a safety net,
plus the HAR-level avoidRenderBlocking and the third-party rules in
bestpractice / info. The header-based rules (cross-origin-*-policy,
NEL, Reporting-Endpoints, Permissions-Policy, X-Content-Type-Options)
each get a negative case against an existing fixture and a positive
case built by cloning the fixture and pushing the target header on the
document response — the same pattern technologyTest already used inline.
The reCAPTCHA and mixed-content rules clone a fixture and inject a
matching asset to exercise the positive path.
bestpractice / info. The header-based rules (cross-origin-*-policy,
NEL, Reporting-Endpoints, Permissions-Policy, X-Content-Type-Options)
each get a negative case against an existing fixture and a positive
case built by cloning the fixture and pushing the target header on the
document response — the same pattern technologyTest already used inline.
The reCAPTCHA and mixed-content rules clone a fixture and inject a
matching asset to exercise the positive path.
The third-party rules (privacy/thirdPartyPrivacy, bestpractice/thirdParty,
info/thirdParty) lean on the existing http://www.nytimes.com.har fixture with
the firstParty option set so pagexray classifies the off-domain assets
correctly — that fixture has real surveillance-categorised tracking and
exercises the score=0 branch end-to-end.
A small firstAdviceForHar(har, options) helper was added to
test/help/har.js so the clone-and-run pattern doesn't need to be copied
around the new tests.
Co-authored-by: Claude noreply@anthropic.com