Vendor the Wappalyzer engine, drop the deprecated wappalyzer-core dep#169
Merged
Conversation
wappalyzer-core is unmaintained on npm — the package is marked deprecated, ships with a Proprietary license tag, and prints a warning on every install even though it is a few hundred lines of zero-dependency pattern matching. Coach-core already vendors the data from enthec/webappanalyzer; the engine is the only piece still pulled in. The port in lib/technologies/wappalyzer.js keeps the same public surface (setTechnologies, setCategories, analyze, resolve), the same pattern parsing, and the same implies/excludes resolution, so behaviour is unchanged — the existing technology tests (real WordPress HAR fixture, plus the CSP-leak and third-party-headers safety checks) all pass against the port. The benchmarking instrumentation and CommonJS wrapping were dropped on the way since neither was used. getWappalyzerCoreVersion now reports coach-core's own version, which is the thing that actually changes when the engine changes; the data version is still available separately via getTechnologiesVersion. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wappalyzer-core is unmaintained on npm — the package is marked deprecated,
ships with a Proprietary license tag, and prints a warning on every install
even though it is a few hundred lines of zero-dependency pattern matching.
Coach-core already vendors the data from enthec/webappanalyzer; the engine
is the only piece still pulled in.
The port in lib/technologies/wappalyzer.js keeps the same public surface
(setTechnologies, setCategories, analyze, resolve), the same pattern parsing,
and the same implies/excludes resolution, so behaviour is unchanged — the
existing technology tests (real WordPress HAR fixture, plus the CSP-leak and
third-party-headers safety checks) all pass against the port. The
benchmarking instrumentation and CommonJS wrapping were dropped on the way
since neither was used.
getWappalyzerCoreVersion now reports coach-core's own version, which is the
thing that actually changes when the engine changes; the data version is
still available separately via getTechnologiesVersion.
Co-authored-by: Claude noreply@anthropic.com