Drop filter-files and mkdirp in favour of native fs#168
Merged
Conversation
The combine build step used filter-files to enumerate category directories and JS files under lib/dom, and mkdirp in an npm script to create the dist output directory. Both jobs are a few lines of node:fs (readdirSync, statSync, mkdirSync recursive), so the dependencies were carrying their weight purely to spell those primitives. The combine script now ensures its own output directory exists, which lets the npm script collapse to a single node call. With this change coach-core ships with three runtime dependencies — pagexray, third-party-web, wappalyzer-core — and no incidental ones. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combine build step used filter-files to enumerate category directories
and JS files under lib/dom, and mkdirp in an npm script to create the dist
output directory. Both jobs are a few lines of node:fs (readdirSync,
statSync, mkdirSync recursive), so the dependencies were carrying their
weight purely to spell those primitives.
The combine script now ensures its own output directory exists, which lets
the npm script collapse to a single node call. With this change coach-core
ships with three runtime dependencies — pagexray, third-party-web,
wappalyzer-core — and no incidental ones.
Co-authored-by: Claude noreply@anthropic.com