Replace lodash.groupby with a small inline helper#167
Merged
Conversation
The single use site in harCutter groups HAR entries by their pageref so the right subset can be picked out for a given page. It is a trivial loop, and keeping a dedicated lodash.* package around for one call was hard to justify. Inlining the helper removes the last lodash runtime dependency from coach-core. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single use site in harCutter groups HAR entries by their pageref so the
right subset can be picked out for a given page. It is a trivial loop, and
keeping a dedicated lodash.* package around for one call was hard to
justify. Inlining the helper removes the last lodash runtime dependency
from coach-core.
Co-authored-by: Claude noreply@anthropic.com