Modernize lint stack and convert to ESM#20
Merged
Conversation
Replace eslint 5 / prettier 1 (2018) with the same flat-config setup that
sitespeed.io uses: eslint 10 + eslint-plugin-unicorn + current
prettier/config-prettier/plugin-prettier. The unicorn rules push the
package away from CommonJS, so flip the package to "type": "module" and
rewrite require/module.exports/__dirname with import/export and
import.meta.url. Browsertime already imports via
await import('@sitespeed.io/chromedriver') and reads .default.binPath(),
which still works under the new exports.
While there, drop the dead eslint-check script that referenced a
non-existent .eslintrc.js, and rely on top-level await in the two CLI
scripts (install.js, check-latest.js) so we can drop the explicit
promise-chain catch wrappers that unicorn flagged.
Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace eslint 5 / prettier 1 (2018) with the same flat-config setup that
sitespeed.io uses: eslint 10 + eslint-plugin-unicorn + current
prettier/config-prettier/plugin-prettier. The unicorn rules push the
package away from CommonJS, so flip the package to "type": "module" and
rewrite require/module.exports/__dirname with import/export and
import.meta.url. Browsertime already imports via
await import('@sitespeed.io/chromedriver') and reads .default.binPath(),
which still works under the new exports.
While there, drop the dead eslint-check script that referenced a
non-existent .eslintrc.js, and rely on top-level await in the two CLI
scripts (install.js, check-latest.js) so we can drop the explicit
promise-chain catch wrappers that unicorn flagged.
Co-authored-by: Claude noreply@anthropic.com