Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for TypolinkParameter objects in TYPO3 v13 #165

Merged
merged 6 commits into from
Jan 21, 2025
+62 −11
Merged

[FEATURE] Support for TypolinkParameter objects in TYPO3 v13 #165

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8302b57
[FEATURE] Support for TypolinkParameter objects in TYPO3 v13
s2b Oct 19, 2024
765dd78
[TASK] Define explicit nullable types for compatibility with PHP 8.4
Jan 20, 2025
99010d0
Merge branch 'sitegeist:master' into master
s2b Jan 21, 2025
74b0943
Merge pull request #3 from koehnlein/feature/php84
s2b Jan 21, 2025
bc93b75
[TASK] Add PHP 8.4 to testing matrix
Jan 21, 2025
11379f6
Merge pull request #4 from koehnlein/feature/php84
s2b Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
[TASK] Define explicit nullable types for compatibility with PHP 8.4
Albrecht Köhnlein committed Jan 20, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 765dd786b0edd89d3ee8a7884d90fcda2bc67ffa
2 changes: 1 addition & 1 deletion Classes/Service/XsdGenerator.php
View file
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ protected function getDefaultPrefixForNamespace(string $namespace): int|string
*
* @return array Array of generated XML target namespaces
*/
public function generateXsd(string $path, string $namespace = null): array
public function generateXsd(string $path, ?string $namespace = null): array
{
$generatedNameSpaces = [];
$namespaces = $this->componentLoader->getNamespaces();
14 changes: 7 additions & 7 deletions Classes/ViewHelpers/Form/TranslatedValidationResultsViewHelper.php
View file
Original file line number Diff line number Diff line change
@@ -162,10 +162,10 @@ protected static function translateMessage(
RenderingContextInterface $renderingContext,
Message $message,
string $translatePrefix = '',
RootRenderableInterface $element = null,
string $extensionName = null,
string $languageKey = null,
array $alternativeLanguageKeys = null
?RootRenderableInterface $element = null,
?string $extensionName = null,
?string $languageKey = null,
?array $alternativeLanguageKeys = null
) {
// Make sure that messages are translated only once
$hash = spl_object_hash($message);
@@ -229,9 +229,9 @@ public static function translateValidationError(
int $code,
array $arguments,
string $defaultValue = '',
string $extensionName = null,
string $languageKey = null,
array $alternativeLanguageKeys = null
?string $extensionName = null,
?string $languageKey = null,
?array $alternativeLanguageKeys = null
): ?string {
if ($alternativeLanguageKeys) {
trigger_error('Calling translatedValidationResults with the argument $alternativeLanguageKeys will be removed in fluid-components 4.0', E_USER_DEPRECATED);