Fixed all tests and float2scalar logic#62
Merged
abaranov25 merged 3 commits intosintel-dev:masterfrom Feb 19, 2026
Merged
Conversation
sarahmish
reviewed
Feb 19, 2026
Contributor
sarahmish
left a comment
sarahmish
left a comment
There was a problem hiding this comment.
Looks good @abaranov25, just one change
pyproject.toml
Outdated
| dependencies = [ | ||
| 'pip<=24.1', | ||
| 'setuptools', | ||
| 'wheel', |
Contributor
There was a problem hiding this comment.
move these to dev instead, it's only required when running make install-develop
Contributor
There was a problem hiding this comment.
I think you can also remove them because the github workflow already requires these to be installed.
https://github.com/sintel-dev/sigllm/blob/master/.github/workflows/tests.yml#L23
sarahmish
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce pip dependency backtracking and fix failing test/lint issues with previously merged PR.