Skip to content

Disable reading time on TIL posts #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sinon merged 1 commit into from
Aug 30, 2025
Merged

Disable reading time on TIL posts #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions templates/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
{% extends "after-dark/templates/page.html" %}

{% block content %}
{% if 'tils' in page.path %}
<style>
.muted svg.i-clock,
.muted svg.i-clock+span {
display: none !important;
}
</style>
Comment on lines +5 to +10
Copy link

Copilot AI Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CSS rule is duplicated between templates/section.html and templates/page.html. Consider extracting this to a shared CSS file or creating a reusable template block to avoid code duplication.

Suggested change
<style>
.muted svg.i-clock,
.muted svg.i-clock+span {
display: none !important;
}
</style>
{% include "shared/muted-clock-style.html" %}

Copilot uses AI. Check for mistakes.
{% endif %}
{{ super() }}
{% endblock %}

{% block extra_footer %}
<script src="https://utteranc.es/client.js" repo="sinon/sinon.github.io" issue-term="url" label="comments"
theme="github-dark" crossorigin="anonymous" async>
Expand Down
15 changes: 14 additions & 1 deletion templates/section.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
{% extends "index.html" %}
{% extends "index.html" %}

{% block content %}
<style>
.tils-section .muted svg.i-clock,
.tils-section .muted svg.i-clock+span {
display: none !important;
}
</style>

Comment on lines +4 to +10
Copy link

Copilot AI Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles in templates should be avoided. Consider moving this CSS to a separate stylesheet or using a more maintainable approach like CSS classes that can be conditionally applied.

Suggested change
<style>
.tils-section .muted svg.i-clock,
.tils-section .muted svg.i-clock+span {
display: none !important;
}
</style>

Copilot uses AI. Check for mistakes.
<div class="section-content{% if section.title == 'TILs' or 'til' in section.slug %} tils-section{% endif %}">
Copy link

Copilot AI Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition 'til' in section.slug will always evaluate to True because it's not properly grouped with the first condition. It should be (section.title == 'TILs') or ('til' in section.slug) to work as intended.

Suggested change
<div class="section-content{% if section.title == 'TILs' or 'til' in section.slug %} tils-section{% endif %}">
<div class="section-content{% if (section.title == 'TILs') or ('til' in section.slug) %} tils-section{% endif %}">

Copilot uses AI. Check for mistakes.
{{ super() }}
</div>
{% endblock %}
Loading