feat: New snippets format (Numbers) and launcher #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsk-sinch
reviewed
Jun 2, 2025
matsk-sinch
approved these changes
Jun 3, 2025
* feat: Support 'config.properties' file to be shared across snippets
JPPortier
force-pushed
the
DEVEXP-876-new-snippets
branch
from
9ff3087 to
cbaeeab
Compare
matsk-sinch
reviewed
Jun 20, 2025
matsk-sinch
previously approved these changes
Jun 23, 2025
JPPortier
dismissed stale reviews from alex-sberna and matsk-sinch
snippets updated
asein-sinch
reviewed
Jun 26, 2025
| @@ -44,16 +47,17 @@ public static void main(String[] args) { | |||
|
|
|||
| NumbersService service = client.numbers().v1(); | |||
|
|
|||
| Capability capability = Capability.SMS; | |||
There was a problem hiding this comment.
I think it was ok to keep the SMS capability as the number will be configured for SMS sending
There was a problem hiding this comment.
Yes ... and it is not a required parameter and wanted to keep consistent requests across SDKs (Node currently do not set it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alex-sberna / everyone