Skip to content

chore(audits): drop dead ESLint directives and redundant check:dead-code; fix the PPTX blend-group call they hid - #8876

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/guardrails-audits
Oct 10, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/guardrails-audits

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove all 89 eslint-disable / eslint-enable comments. Nothing runs ESLint (no eslint package or config in any workspace, every lint script is Biome, and next build 16.4 has no lint step), so they suppressed nothing and implied rules that don't exist. Where a directive carried a reason, the reason stays as a plain // why
  • check:comment-hygiene now rejects ESLint directives, so they can't come back (two cases added to its existing test file; the flagging case fails against the old script)
  • Fix a real bug the directives were hiding in the PPTX renderer: svg.appendChild(group)(path as any).__rectBlendGroup = undefined called the appended element as a function and threw whenever a rect gradient blend group existed. Split into the two statements it was meant to be
  • Drop check:dead-code: check:unused-exports already runs knip with the same config and a superset of issue types, and check:audits already skipped the alias. The knip config stays
  • Ignore the generated apps/docs/components/icons.tsx (a verbatim copy written by generate-docs.ts) in knip; its export surface is already ratcheted at the source file. The unused-exports baseline shrinks by 66 entries
  • CLAUDE.md and the you-might-not-need-a-comment skill updated to match

Type of Change

  • Bug fix
  • Other: dead code and audit cleanup

Testing

  • Ran check:comment-hygiene (passes; flags all 89 directives on staging), its test file (10/10), and check:unused-exports (passes with the shrunk baseline); biome check on every changed file
  • Full lint, audits, type-check and test suites run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ad-code script

- Remove all 89 `eslint-disable` comments. Nothing runs ESLint (no eslint dependency or
  config in any workspace; Next 16 `next build` has no lint step), so they suppressed
  nothing. Reasons they carried are kept as plain `//` whys.
- `check:comment-hygiene` now rejects `eslint-disable`/`eslint-enable` comments so they
  cannot return.
- Remove `check:dead-code`: `check:unused-exports` already runs knip with the same config
  and a superset of its issue types, and `check:audits` skipped the alias.
- Ignore unused exports in the generated `apps/docs/components/icons.tsx` (a verbatim copy
  of the sim icon set, whose export surface is ratcheted at the source) and shrink the
  unused-exports baseline by its 66 entries.
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 10, 2026 02:07
@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 10, 2026 2:21am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 48 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .agents/skills/you-might-not-need-a-comment/SKILL.md Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with the previous test-coverage concern addressed.

Summary

Removes unused ESLint directives, rejects new ones through check:comment-hygiene, and removes the redundant check:dead-code script. It also fixes the PPTX rectangular-gradient crash and excludes generated docs icons from unused-export checks.

  • Rectangular gradient shapes add their blend group before the main path.
  • The comment check rejects ESLint directives in source comments.
  • The unused-code audit runs through one Knip check.
  • Source code keeps its behavior without dead ESLint comments.

Reviews (3) · Last reviewed commit: "test(pptx): cover the rect gradient blen..." · Reviewed by Greptile

Comment thread apps/sim/lib/pptx-renderer/renderer/shape-renderer.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 49 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cf4e2d4 into staging Oct 10, 2026
56 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/guardrails-audits branch October 10, 2026 03:45

This branch was previously deployed

1 inactive deployment
Preview — 1b24113b Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant