Skip to content

fix(provenance): align file matching and report withheld attachments - #7867

Merged
icecrasher321 merged 3 commits into
stagingfrom
codex/fix-required-attachment-provenance
Sep 16, 2026
Merged

icecrasher321 merged 3 commits into
stagingfrom
codex/fix-required-attachment-provenance

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Agent and Copilot turns running when file-provenance checks withhold an attachment. Add a shared model-visible attachment-error notice so answers account for unavailable input without exposing the withheld file's bytes or metadata.
  • Apply the shared literal policy before expanding JSON-escaped scan values. Short compiled values cannot acquire protected provenance through escaping, and successfully decrypted short mounted values cannot taint derived binary exports.
  • Preserve protection for literals of eight or more characters, unreadable provenance, and binary exports with protected secrets in scope. Keep feature flags and legacy compatibility unchanged.

Type of Change

  • Bug fix

Testing

  • Bun 1.4.1: 767 focused tests covering shared matching, mounted and compiled output classification, durable-file admission, and Agent/Copilot continuation. New deterministic regressions reproduce both short-literal classification failures before the fix.
  • 14 integration tests with disposable PostgreSQL, Redis, and local file storage covering external downloads, archive copies, and model admission.
  • App type-check, repository lint, all 46 audits (including API validation), block-registry check, and generated-artifact checks.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 16, 2026 12:01am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge and consistently fails before model execution when requested attachments cannot pass provenance admission.

Summary

The PR replaces silent omission of provenance-refused model attachments with explicit request failure across Agent, Copilot, and provider boundaries.

  • Agent-generated documents now fail before provider execution when an embedded contributor is not model-safe.
  • Copilot validates both supported initial attachment fields without mutating the caller’s payload.
  • The shared provider boundary refuses mixed safe/unsafe attachment sets before upload or provider processing.
  • Focused tests cover safe and unsafe generated documents, both Copilot attachment aliases, mixed sets, and streaming and non-streaming provider requests.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Agent or Copilot request] --> B[Collect model attachments]
  B --> C[Import durable provenance]
  C --> D{All attachments model-safe?}
  D -->|Yes| E[Hydrate or upload attachments]
  E --> F[Execute provider request]
  D -->|No| G[Fail request explicitly]
Loading

Reviews (1) · Last reviewed commit: "fix(provenance): stop silently dropping ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321 icecrasher321 changed the title fix(provenance): stop silently dropping model attachments fix(provenance): report withheld attachments without stopping model turns Sep 15, 2026
@icecrasher321
icecrasher321 force-pushed the codex/fix-required-attachment-provenance branch from 632aef4 to d67ada7 Compare September 15, 2026 23:48
@icecrasher321
icecrasher321 force-pushed the codex/fix-required-attachment-provenance branch from d67ada7 to aa9f388 Compare September 16, 2026 00:01
@icecrasher321 icecrasher321 changed the title fix(provenance): report withheld attachments without stopping model turns fix(provenance): align file matching and report withheld attachments Sep 16, 2026
@icecrasher321
icecrasher321 merged commit 8e14e4d into staging Sep 16, 2026
32 of 33 checks passed
@icecrasher321
icecrasher321 deleted the codex/fix-required-attachment-provenance branch September 16, 2026 00:07

This branch was previously deployed

1 inactive deployment
Preview aa9f3882 Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant